Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compatibility with PHP 7.1 and 7.2 #60

Merged
merged 8 commits into from
Jan 4, 2021
Merged

fix: compatibility with PHP 7.1 and 7.2 #60

merged 8 commits into from
Jan 4, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 4, 2021 •
edited
Loading

Closes #59

Proposed Changes

  • Fixed compatibility with PHP 7.1 and 7.2
  • Added PHP 8 to CI
  • Added code style checking

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review January 4, 2021 10:57
@bednar bednar requested a review from rhajek January 4, 2021 10:58
@bednar bednar added this to the 1.10.0 milestone Jan 4, 2021
@bednar bednar merged commit fdb2667 into master Jan 4, 2021
@bednar bednar deleted the chore/php-compatibility branch January 4, 2021 13:45
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
@bednar @peynman
fix: compatibility with PHP 7.1 and 7.2 (influxdata#60)
2cac72a 
* Added PHP 8 to CI
* Added code style checking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

PHP function array_key_last() not available for versions < 7.3
2 participants
@bednar @rhajek