Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added exponentialBase to WriteApi #35

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Conversation

rolincova
Copy link
Contributor

Closes

Added exponentialBase to WriteApi

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@rolincova rolincova force-pushed the feat/exponential-base branch from 65c2dc4 to b183984 Compare August 12, 2020 08:23
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #35 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     85.69%   85.73%   +0.04%     
+ Complexity      276      275       -1     
============================================
  Files            15       15              
  Lines           629      631       +2     
============================================
+ Hits            539      541       +2     
  Misses           90       90              
Impacted Files Coverage Δ Complexity Δ
src/InfluxDB2/WriteApi.php 98.66% <100.00%> (+0.01%) 32.00 <0.00> (-1.00) ⬆️
src/InfluxDB2/WriteOptions.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf207b...ea32a59. Read the comment docs.

README.md Outdated
@@ -150,9 +150,9 @@ The writes are processed in batches which are configurable by `WriteOptions`:
| **writeType** | type of write SYNCHRONOUS / BATCHING / | SYNCHRONOUS |
| **batchSize** | the number of data point to collect in batch | 10 |
| **retryInterval** | the number of milliseconds to retry unsuccessful write. The retry interval is "exponentially" used when the InfluxDB server does not specify "Retry-After" header. | 1000 |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 5000

@rolincova rolincova requested a review from bednar August 12, 2020 08:27
@bednar bednar merged commit a36f1d2 into master Aug 13, 2020
@bednar bednar deleted the feat/exponential-base branch August 13, 2020 06:12
@bednar bednar added this to the 1.6.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants