Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added retryInterval, maxRetries and maxRetryDelay to WriteApi #32

Merged
merged 6 commits into from
Jul 29, 2020

Conversation

rolincova
Copy link
Contributor

@rolincova rolincova commented Jul 27, 2020

Closes

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #32 into master will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     85.36%   85.71%   +0.34%     
- Complexity      269      276       +7     
============================================
  Files            15       15              
  Lines           615      630      +15     
============================================
+ Hits            525      540      +15     
  Misses           90       90              
Impacted Files Coverage Δ Complexity Δ
src/InfluxDB2/WriteApi.php 98.64% <100.00%> (+0.26%) 33.00 <7.00> (+7.00)
src/InfluxDB2/WriteOptions.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e907c...2523bfb. Read the comment docs.

@rolincova rolincova requested a review from bednar July 27, 2020 10:03
@rolincova rolincova force-pushed the feat/retry-interval branch from fb79dc7 to b3ceb21 Compare July 27, 2020 10:17
src/InfluxDB2/WriteApi.php Outdated Show resolved Hide resolved
src/InfluxDB2/WriteApi.php Outdated Show resolved Hide resolved
src/InfluxDB2/WriteApi.php Outdated Show resolved Hide resolved
src/InfluxDB2/WriteApi.php Outdated Show resolved Hide resolved
@rolincova rolincova changed the title feat: Added retryInterval and maxRetries to WriteApi feat: Added retryInterval, maxRetries and maxRetryDelay to WriteApi Jul 28, 2020
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit cc9d6e2 into master Jul 29, 2020
@bednar bednar deleted the feat/retry-interval branch July 29, 2020 13:52
@bednar bednar added this to the 1.6.0 milestone Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants