Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved documentation about batching, WriteOptions, WriteType should be in separate file #24

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 20, 2020

Closes #23

  1. Improved documentation about batching
  2. WriteOptions, WriteType should be in an separate file - see PSR-4: Autoloader
  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

Sorry, something went wrong.

@bednar bednar added the enhancement New feature or request label Apr 20, 2020
@bednar bednar added this to the 1.3.0 milestone Apr 20, 2020
@codecov-io
Copy link

codecov-io commented Apr 20, 2020

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     85.31%   85.31%           
  Complexity      271      271           
=========================================
  Files            14       15    +1     
  Lines           613      613           
=========================================
  Hits            523      523           
  Misses           90       90           
Impacted Files Coverage Δ Complexity Δ
src/InfluxDB2/WriteApi.php 98.38% <ø> (-0.10%) 26.00 <0.00> (-4.00)
src/InfluxDB2/WriteOptions.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75969b...189653d. Read the comment docs.

@bednar bednar merged commit f623e81 into master Apr 20, 2020
@bednar bednar deleted the docs/batching branch April 20, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$write_api->write is really slow
2 participants