-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close the UdpWriter #144
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
============================================
- Coverage 74.93% 74.86% -0.07%
Complexity 424 424
============================================
Files 25 25
Lines 1093 1094 +1
============================================
Hits 819 819
- Misses 274 275 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sokil thanks for your PR 👍
Can you please satisfy our checklist
? After that we will be able to merge this PR:
43da760
to
2feb65c
Compare
done |
@sokil thanks again for PR 👍 |
Thank you for quick feedback!! |
Proposed Changes
If UPD socket was previously closed by
\InfluxDB2\UdpWriter::close
and new write occured, error will be obtainedsocket_sendto(): Argument #1 ($socket) has already been closed
This is because method
close
does not unset socket property:And
getSocket
does not create new connection because old still insocket
property:Checklist
make test
completes successfully