-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FluxRecord.row with response data stored in Array #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:
Codecov ReportBase: 74.67% // Head: 74.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
============================================
+ Coverage 74.67% 74.93% +0.25%
- Complexity 421 424 +3
============================================
Files 25 25
Lines 1082 1093 +11
============================================
+ Hits 808 819 +11
Misses 274 274
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌹
Proposed Changes
Adding possibility of accessing response data in Array FluxRecord.row.
In case of using pivot on data, where field contains labels that occur by default in the annotated CSV (f.e. "result" or "table"), could be duplicated column names in response. In that case FluxRecord.values, which hold only unique keys, doesn't show complete data. This edge case is solved by using FluxRecord.row.
Checklist
make test
completes successfully