Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Using DateTimeInterface to be more compatible with all DateTime #117

Merged
merged 1 commit into from
Feb 17, 2022
Merged

feat: Using DateTimeInterface to be more compatible with all DateTime #117

merged 1 commit into from
Feb 17, 2022

Conversation

hotfix31
Copy link
Contributor

Using DateTimeInterface to be more compatible with all DateTime objects (like DateTimeImmutable) in Point.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@hotfix31 hotfix31 force-pushed the feature/change-datetime-interface branch from 265af68 to cb0f62d Compare February 16, 2022 23:16
@hotfix31 hotfix31 marked this pull request as ready for review February 16, 2022 23:17
@hotfix31 hotfix31 changed the title Using DateTimeInterface to be more compatible with all DateTime feat: Using DateTimeInterface to be more compatible with all DateTime Feb 16, 2022
bednar
bednar approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hotfix31, thanks for your PR 👍

LGTM

@bednar bednar merged commit 59a5e15 into influxdata:master Feb 17, 2022
@bednar bednar added the enhancement New feature or request label Feb 17, 2022
@bednar bednar added this to the 2.6.0 milestone Feb 17, 2022
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
@hotfix31 @peynman
feat: change to DateTimeInterface typehint to be more compatible with…
42fc597 
… other DateTime objects (influxdata#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hotfix31 @bednar