Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameterized queries #107

Merged
merged 4 commits into from
Jan 11, 2022
Merged

feat: add parameterized queries #107

merged 4 commits into from
Jan 11, 2022

Conversation

rhajek
Copy link
Contributor

@rhajek rhajek commented Dec 16, 2021

Proposed Changes

This PR implements support for Parameterized Queries for InfluxDB Cloud.
https://docs.influxdata.com/influxdb/cloud/query-data/parameterized-queries

Closes #56

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@rhajek rhajek requested a review from bednar December 16, 2021 12:16
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM php:7.1-cli AS dev
FROM php:7.4-cli AS dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended? The required version of php in composer.json is >=7.1.

Suggested change
FROM php:7.4-cli AS dev
FROM php:7.1-cli AS dev

examples/ParameterizedQuery.php Show resolved Hide resolved
src/InfluxDB2/QueryApi.php Outdated Show resolved Hide resolved
src/InfluxDB2/QueryApi.php Outdated Show resolved Hide resolved
src/InfluxDB2/QueryApi.php Outdated Show resolved Hide resolved
@rhajek rhajek requested a review from bednar January 11, 2022 13:07
@bednar bednar added this to the 2.5.0 milestone Jan 11, 2022
@bednar bednar merged commit 82f551a into master Jan 11, 2022
@bednar bednar deleted the feat/query_params branch January 11, 2022 19:41
peynman pushed a commit to peynman/influxdb-client-php that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SECURITY: Missing support for prepared statements
2 participants