Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contains filter [FluxDSL] #354

Merged
merged 6 commits into from
May 23, 2022
Merged

Conversation

yoobi
Copy link
Contributor

@yoobi yoobi commented May 20, 2022

Closes #353

Proposed Changes

Briefly describe your proposed changes:

Adding contains filter

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar changed the title dev: add contains filter + test feat: add contains filter [FluxDSL] May 23, 2022
@bednar bednar self-requested a review May 23, 2022 06:04
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoobi Thanks for your PR 👍

@bednar bednar self-requested a review May 23, 2022 06:14
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov-commenter
Copy link

Codecov Report

Merging #354 (7fb13e7) into master (4ee481b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #354      +/-   ##
============================================
+ Coverage     88.97%   88.99%   +0.01%     
  Complexity      634      634              
============================================
  Files           155      155              
  Lines          6333     6340       +7     
  Branches        302      302              
============================================
+ Hits           5635     5642       +7     
  Misses          612      612              
  Partials         86       86              
Impacted Files Coverage Δ
...y/dsl/functions/restriction/ColumnRestriction.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee481b...7fb13e7. Read the comment docs.

@bednar bednar merged commit c1455f3 into influxdata:master May 23, 2022
@bednar bednar added this to the 6.2.0 milestone Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux DSL - contains function
3 participants