Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactive): do not deliver exception when the consumer is disposed #313

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Mar 16, 2022

Closes #311

Proposed Changes

Do not deliver throwable if the consumer is already disposed or cancelled.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #313 (8c72087) into master (8f2c513) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
- Coverage     88.97%   88.95%   -0.03%     
  Complexity      473      473              
============================================
  Files           149      149              
  Lines          6005     6010       +5     
  Branches        290      290              
============================================
+ Hits           5343     5346       +3     
- Misses          580      581       +1     
- Partials         82       83       +1     
Impacted Files Coverage Δ
...client/reactive/internal/QueryReactiveApiImpl.java 77.66% <71.42%> (-0.91%) ⬇️
...n/java/com/influxdb/internal/AbstractQueryApi.java 52.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2c513...8c72087. Read the comment docs.

@bednar bednar requested a review from rhajek March 16, 2022 07:52
@bednar bednar marked this pull request as ready for review March 16, 2022 07:52
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 1d5d8ec into master Mar 22, 2022
@bednar bednar deleted the fix_on_error branch March 22, 2022 09:09
@bednar bednar added this to the 5.1.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryReactiveApi The exception could not be delivered to the consumer because it has already canceled/disposed
3 participants