Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapping measurement with primitive float #294

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 7, 2022

Closes #293

Proposed Changes

Fixed mapping primitive floats into LineProtocol.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review January 7, 2022 07:53
@bednar bednar requested a review from rhajek January 7, 2022 07:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #294 (b3253ee) into master (5ca93a5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #294      +/-   ##
============================================
+ Coverage     88.85%   88.92%   +0.06%     
  Complexity      473      473              
============================================
  Files           149      149              
  Lines          5987     5988       +1     
  Branches        289      290       +1     
============================================
+ Hits           5320     5325       +5     
+ Misses          581      580       -1     
+ Partials         86       83       -3     
Impacted Files Coverage Δ
...om/influxdb/client/internal/MeasurementMapper.java 97.33% <100.00%> (+5.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca93a5...b3253ee. Read the comment docs.

Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 62c9a1e into master Jan 7, 2022
@bednar bednar deleted the fix/measurement-float-mapping branch January 7, 2022 08:53
@bednar bednar added this to the 4.1.0 milestone Jan 7, 2022
@bednar bednar added the bug Something isn't working label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior - Float vs float
3 participants