Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session authentication for InfluxDB 2.1 #279

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Nov 10, 2021

Proposed Changes

The InfluxDB 2.1 OSS changed name of session cookie to influxdb-oss-session. As a solution this PR store all cookies from auth request.

influxdata/influxdb#22632

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #279 (141e084) into master (7e4b969) will decrease coverage by 0.02%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
- Coverage     88.39%   88.37%   -0.03%     
  Complexity      473      473              
============================================
  Files           148      148              
  Lines          5867     5865       -2     
  Branches        275      276       +1     
============================================
- Hits           5186     5183       -3     
  Misses          601      601              
- Partials         80       81       +1     
Impacted Files Coverage Δ
...luxdb/client/internal/AuthenticateInterceptor.java 96.82% <93.33%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4b969...141e084. Read the comment docs.

@bednar bednar marked this pull request as ready for review November 10, 2021 08:47
@bednar bednar requested a review from rhajek November 10, 2021 08:47
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhajek rhajek merged commit 798ff29 into master Nov 15, 2021
@rhajek rhajek deleted the fix/authorization-cookie branch November 15, 2021 08:45
@bednar bednar added this to the 3.5.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants