-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add query method with all params for BucketsApi, OrganizationApi and TasksApi #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/src/main/java/com/influxdb/client/internal/BucketsApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/OrganizationsApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java
Outdated
Show resolved
Hide resolved
@bednar I will satisfy the PR checklist tomorrow or next week |
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…pl.java Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…sApiImpl.java Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
….java Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
….java Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
….java Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
@bednar Is there anything else that need me to be done?I haven't run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to create a new rebased PR, I will squash the commits before merge the PR into master.
There are only a few requirements before merge the PR into master:
- Update
CHANGELOG.md
- Satisfy following requirements:
client/src/main/java/com/influxdb/client/internal/BucketsApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/OrganizationsQuery.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…pl.java Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
@bednar CHANGELOG.md updated |
Please, fix a compilation error:
You have to rename |
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
============================================
- Coverage 89.05% 88.39% -0.66%
Complexity 473 473
============================================
Files 145 148 +3
Lines 5791 5867 +76
Branches 275 275
============================================
+ Hits 5157 5186 +29
- Misses 554 601 +47
Partials 80 80
Continue to review full report at Codecov.
|
@bednar fixed for ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for PR
LGTM 💯
Closes #277
Proposed Changes
add query with full rest params for buckets,org and tasks api.
Checklist
mvn test
completes successfully