Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add query method with all params for BucketsApi, OrganizationApi and TasksApi #278

Merged
merged 46 commits into from
Nov 5, 2021

Conversation

lonelyleaf
Copy link
Contributor

@lonelyleaf lonelyleaf commented Nov 4, 2021

Closes #277

Proposed Changes

add query with full rest params for buckets,org and tasks api.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Sign CLA (if not already signed)

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍.

Please, satisfy the PR checklist:

image

and there are also code style requirements:

@lonelyleaf
Copy link
Contributor Author

@bednar I will satisfy the PR checklist tomorrow or next week

@bednar
Copy link
Contributor

bednar commented Nov 4, 2021

Thanks, you can easily satisfy request by:

image

lonelyleaf and others added 25 commits November 4, 2021 21:27
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…pl.java

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…sApiImpl.java

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
….java

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
….java

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
….java

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
@lonelyleaf
Copy link
Contributor Author

@bednar Is there anything else that need me to be done?I haven't run mvn test and should I open anyother PR and rebase those commit?(´・_・`)

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to create a new rebased PR, I will squash the commits before merge the PR into master.

There are only a few requirements before merge the PR into master:

  1. Update CHANGELOG.md
  2. Satisfy following requirements:

@bednar bednar changed the title add query with full rest params for buckets,org and tasks api. feat: add query method with all params for BucketsApi, OrganizationApi and TasksApi Nov 5, 2021
lonelyleaf and others added 15 commits November 5, 2021 15:41
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…pl.java

Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
@lonelyleaf
Copy link
Contributor Author

@bednar CHANGELOG.md updated

@bednar
Copy link
Contributor

bednar commented Nov 5, 2021

Please, fix a compilation error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project influxdb-client-java: Compilation failure: Compilation failure: 
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/TaskQuery.java:[26,8] class TasksQuery is public, should be declared in a file named TasksQuery.java
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/TasksApi.java:[276,41] cannot access com.influxdb.client.TaskQuery
[ERROR]   bad source file: /home/circleci/project/client/src/main/java/com/influxdb/client/TaskQuery.java
[ERROR]     file does not contain class com.influxdb.client.TaskQuery
[ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java:[140,48] cannot find symbol
[ERROR]   symbol:   class TaskQuery
[ERROR]   location: class com.influxdb.client.internal.TasksApiImpl
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java:[130,15] cannot find symbol
[ERROR]   symbol:   class TaskQuery
[ERROR]   location: class com.influxdb.client.internal.TasksApiImpl
[ERROR] /home/circleci/project/client/src/main/java/com/influxdb/client/internal/TasksApiImpl.java:[130,41] cannot find symbol
[ERROR]   symbol:   class TaskQuery
[ERROR]   location: class com.influxdb.client.internal.TasksApiImpl
[ERROR] -> [Help 1]

https://app.circleci.com/pipelines/github/influxdata/influxdb-client-java/1381/workflows/abd10798-16a9-47d3-8528-4b564ec87ff7/jobs/4247

You have to rename TaskQuery to TasksQuery at all places.

@bednar
Copy link
Contributor

bednar commented Nov 5, 2021

The CI builds has to be green ;)

image

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #278 (b277596) into master (59b0d63) will decrease coverage by 0.65%.
The diff coverage is 39.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     89.05%   88.39%   -0.66%     
  Complexity      473      473              
============================================
  Files           145      148       +3     
  Lines          5791     5867      +76     
  Branches        275      275              
============================================
+ Hits           5157     5186      +29     
- Misses          554      601      +47     
  Partials         80       80              
Impacted Files Coverage Δ
...rc/main/java/com/influxdb/client/BucketsQuery.java 0.00% <0.00%> (ø)
...a/com/influxdb/client/internal/BucketsApiImpl.java 70.55% <0.00%> (-2.24%) ⬇️
...n/java/com/influxdb/client/OrganizationsQuery.java 36.84% <36.84%> (ø)
.../src/main/java/com/influxdb/client/TasksQuery.java 63.63% <63.63%> (ø)
...influxdb/client/internal/OrganizationsApiImpl.java 93.02% <100.00%> (+0.10%) ⬆️
...ava/com/influxdb/client/internal/TasksApiImpl.java 84.32% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b0d63...b277596. Read the comment docs.

@lonelyleaf
Copy link
Contributor Author

@bednar fixed for ci

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for PR

LGTM 💯

@bednar bednar merged commit 7e4b969 into influxdata:master Nov 5, 2021
@bednar bednar added this to the 3.5.0 milestone Nov 5, 2021
@bednar bednar added the enhancement New feature or request label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add query by name for buckets,tasks and orgs api
3 participants