Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flux-dsl dependencies exclusion #263

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 7, 2021

Closes #259

Proposed Changes

  • created new module client-utils - base utils for other modules without any dependencies
  • flux-dsl dependes on client-utils not on client-core

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review September 7, 2021 06:42
@bednar bednar requested a review from rhajek September 7, 2021 06:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #263 (cf7d217) into master (829f1ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage     89.17%   89.17%           
- Complexity      449      473   +24     
=========================================
  Files           145      145           
  Lines          5773     5773           
  Branches        272      272           
=========================================
  Hits           5148     5148           
  Misses          545      545           
  Partials         80       80           
Impacted Files Coverage Δ
...nt-utils/src/main/java/com/influxdb/Arguments.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829f1ce...cf7d217. Read the comment docs.

@bednar bednar merged commit f1b0e7a into master Sep 9, 2021
@bednar bednar deleted the fix/flux-dsl-dependency branch September 9, 2021 05:03
@bednar bednar added this to the 3.3.0 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

influxdb-spring:3.2.0 java.lang.NoClassDefFoundError: okhttp3.logging.HttpLoggingInterceptor
3 participants