Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename shift() to timeShift() function #236

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 22, 2021

Closes #235

Proposed Changes

The Flux shift() function was renamed to timeShift() - influxdata/flux#1058

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review June 22, 2021 07:48
@bednar bednar requested a review from rhajek June 22, 2021 07:49
@codecov-commenter
Copy link

Codecov Report

Merging #236 (6307d03) into master (e2adb62) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
  Complexity      442      442           
=========================================
  Files           143      143           
  Lines          5713     5713           
  Branches        270      270           
=========================================
  Hits           5100     5100           
  Misses          534      534           
  Partials         79       79           
Impacted Files Coverage Δ
...dsl/src/main/java/com/influxdb/query/dsl/Flux.java 96.12% <100.00%> (ø)
...om/influxdb/query/dsl/functions/TimeShiftFlux.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2adb62...6307d03. Read the comment docs.

@bednar bednar merged commit 9b5a4bc into master Jun 23, 2021
@bednar bednar deleted the fix/rename-shift-to-timeshift branch June 23, 2021 07:59
@bednar bednar added this to the 2.4.0 milestone Jun 23, 2021
@bertrandp
Copy link

I need this guys ! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function shift() does not match InfluxDB 2 spec
4 participants