-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 replace accept-encoding application/json to null for all clients #205
fix: 🐛 replace accept-encoding application/json to null for all clients #205
Conversation
ceb775c
to
5115baf
Compare
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=========================================
Coverage 88.44% 88.44%
Complexity 447 447
=========================================
Files 139 139
Lines 5512 5512
Branches 226 226
=========================================
Hits 4875 4875
Misses 560 560
Partials 77 77
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
Please, could you also update following APIs:
- https://github.com/antoinedvd/influxdb-client-java/blob/5115baff7dd863b4119f5c40514ddba2db6e2e69/client/src/main/java/com/influxdb/client/internal/QueryApiImpl.java#L796
- https://github.com/antoinedvd/influxdb-client-java/blob/5115baff7dd863b4119f5c40514ddba2db6e2e69/client/src/main/java/com/influxdb/client/internal/QueryApiImpl.java#L814
- https://github.com/antoinedvd/influxdb-client-java/blob/5115baff7dd863b4119f5c40514ddba2db6e2e69/client-reactive/src/main/java/com/influxdb/client/reactive/internal/QueryReactiveApiImpl.java#L121
- https://github.com/antoinedvd/influxdb-client-java/blob/5115baff7dd863b4119f5c40514ddba2db6e2e69/client-reactive/src/main/java/com/influxdb/client/reactive/internal/QueryReactiveApiImpl.java#L259
- https://github.com/antoinedvd/influxdb-client-java/blob/5115baff7dd863b4119f5c40514ddba2db6e2e69/client-scala/src/main/scala/com/influxdb/client/scala/internal/QueryScalaApiImpl.scala#L105
- https://github.com/antoinedvd/influxdb-client-java/blob/5115baff7dd863b4119f5c40514ddba2db6e2e69/client-scala/src/main/scala/com/influxdb/client/scala/internal/QueryScalaApiImpl.scala#L280
?
Yes, I'll do that. 😉 |
- this header is not used for influx 2.0 server because it always send back CSV data - this header blocks the accept-encoding gzip header from the BridgeInterceptor
5115baf
to
efa46cf
Compare
@bednar it's done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍
Proposed Changes
👋 Hi folks, I try make a humble contribution to fix a gzip compression issue during a query.
Accept-Encoding
header is not used for influx 2.0 server because it always send back CSV data (the server didn't care if you asked for JSON)Accept-Encoding: gzip
header from theBridgeInterceptor
(quick look here 👀)Checklist
mvn test
completes successfully