Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query response parser should use UTF-8 encoding #164

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 13, 2020

Closes #162

Proposed Changes

The response from InfluxDB server is encoded in UTF-8 => InputStreamReader should use UTF-8 as en encoding.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review October 13, 2020 12:12
@codecov-io
Copy link

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #164   +/-   ##
=========================================
  Coverage     90.30%   90.30%           
  Complexity      439      439           
=========================================
  Files           138      138           
  Lines          5427     5427           
  Branches        215      213    -2     
=========================================
  Hits           4901     4901           
  Misses          450      450           
  Partials         76       76           
Impacted Files Coverage Δ Complexity Δ
...ava/com/influxdb/query/internal/FluxCsvParser.java 96.94% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee00f8...6a2494e. Read the comment docs.

@bednar bednar merged commit 21497dc into master Oct 16, 2020
@bednar bednar deleted the fix/parse-utf-8 branch October 16, 2020 13:55
@bednar bednar added this to the 1.13.0 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluxCsvParser should be specified character encoding。
3 participants