-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow setting of application name to the User-Agent header value #358
feat: Allow setting of application name to the User-Agent header value #358
Conversation
0433dc0
to
982fdde
Compare
@lesam, As you noted in issue #356, there should be an annoying log message, if the application name is unset. |
It seems reasonable to start with a warning, put it in the release notes/docs, and then maybe upgrade it to an error message in the next version? @dgnorton for thoughts as well. |
Just leaving it as a warning forever is not sufficient, since it will never be noticed. |
982fdde
to
4efa483
Compare
We had an internal discussion in Bonitoo and we are in favor of a warning because such a small feature should not bug users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to use warning
and add a warning to CHANGELOG.md
that it will change to error
in a future version of the client.
7546098
to
e9594f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #356
Proposed Changes
Added new option for setting the application name. Application name is then added to the end of Go client version string: E.g.
Influxdb-client-go/2.10.0 (linux; amd64) IoTHub/1.10
Checklist