fix: Non-empty error channel will not block writes #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
requested changes
May 10, 2022
api/write.go
Outdated
| @@ -103,7 +103,7 @@ func (w *WriteAPIImpl) SetWriteFailedCallback(cb WriteFailedCallback) { | |||
| // The chan is unbuffered and must be drained or the writer will block. | |||
| func (w *WriteAPIImpl) Errors() <-chan error { | |||
| if w.errCh == nil { | |||
| w.errCh = make(chan error) | |||
| w.errCh = make(chan error, 1) | |||
There was a problem hiding this comment.
Please adjust the documentation to match the implementation, the channel is now buffered and contains the last error.
api/write.go
Outdated
Comment on lines
182
to
190
| go func(err error) { | ||
| if err != nil && w.errCh != nil { | ||
| if len(w.errCh) == 0 { | ||
| w.errCh <- err | ||
| } else { | ||
| log.Warn("Cannot write error to error channel, it is not read") | ||
| } | ||
| } | ||
| }(err) |
There was a problem hiding this comment.
This kind of non-blocking write is suspicious to me (at least not idiomatic). Couldn't you simply:
if err != nil && w.errCh != nil {
select {
case w.errCh <- err:
// err consumed by err channel
default:
log.Warn("Cannot write error to error channel, it is full", err)
}
}
vlastahajek
force-pushed
the
fix/write_flush_closing
branch
2 times, most recently
from
ad6374b to
125406a
Compare
vlastahajek
force-pushed
the
fix/write_flush_closing
branch
from
125406a to
d99575f
Compare
sranka
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #318
Proposed Changes
Make sure the non-read error channel will not block write or closing.
Checklist