fix: added mutex around writes to logger struct for concurrent use of many… #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszkowalke
changed the title
vlastahajek
requested changes
Aug 10, 2021
There was a problem hiding this comment.
@mateuszkowalke, thanks for the issue and fix. Just a small change to complete this.
log/logger.go
Outdated
| type logger struct { | ||
| prefix string | ||
| logLevel uint | ||
| sync.Mutex |
There was a problem hiding this comment.
Suggested change
| sync.Mutex | |
| lock sync.Mutex |
Logger has no functionality related to Mutex, so embedding (inheriting) is not needed.
log/logger.go
Outdated
| } | ||
|
|
||
| func (l *logger) SetLogLevel(logLevel uint) { | ||
| l.Lock() |
There was a problem hiding this comment.
Suggested change
| l.Lock() | |
| l.lock.Lock() |
log/logger.go
Outdated
| l.logLevel = logLevel | ||
| l.Unlock() |
There was a problem hiding this comment.
Suggested change
| l.Unlock() | |
| l.lock.Unlock() |
log/logger.go
Outdated
| } | ||
|
|
||
| func (l *logger) LogLevel() uint { | ||
| return l.logLevel | ||
| } | ||
|
|
||
| func (l *logger) SetPrefix(prefix string) { | ||
| l.Lock() |
There was a problem hiding this comment.
Suggested change
| l.Lock() | |
| l.lock.Lock() |
log/logger.go
Outdated
| l.prefix = prefix | ||
| l.Unlock() |
There was a problem hiding this comment.
Suggested change
| l.Unlock() | |
| l.lock.Unlock() |
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 91.78% 91.64% -0.14%
==========================================
Files 23 23
Lines 1984 1988 +4
==========================================
+ Hits 1821 1822 +1
- Misses 108 111 +3
Partials 55 55
Continue to review full report at Codecov.
|
vlastahajek
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… clients
Closes #268
Proposed Changes
added mutex around logger struct
Checklist