Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing retrying from blocking write #239

Merged
merged 3 commits into from
Mar 25, 2021
Merged

fix: Removing retrying from blocking write #239

merged 3 commits into from
Mar 25, 2021

Conversation

vlastahajek
Copy link
Contributor

@vlastahajek vlastahajek commented Mar 24, 2021 •
edited
Loading

Closes #235

Proposed Changes

Blocking write client doesn't use retry handling.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@vlastahajek vlastahajek requested a review from sranka March 24, 2021 12:34
sranka
sranka requested changes Mar 24, 2021
View reviewed changes
api/http/error.go Outdated Show resolved Hide resolved
internal/write/service.go Show resolved Hide resolved
@vlastahajek vlastahajek requested a review from sranka March 24, 2021 18:54
@vlastahajek vlastahajek merged commit 7469a6a into influxdata:master Mar 25, 2021
@vlastahajek vlastahajek deleted the fix/sync_write branch March 25, 2021 07:56
@pabigot pabigot mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WriteAPIBlocking.WritePoint does not always return error if influx not reachable
2 participants
@vlastahajek @sranka