Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null string to bytes conversions #5492

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

mhilton
Copy link
Contributor

@mhilton mhilton commented Jun 12, 2024

Avoid a panic if the bytes conversion function receives a string typed NULL value. The function now returns the same error as for other NULL values.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

Avoid a panic if the bytes conversion function receives a string
typed NULL value. The function now returns the same error as for
other NULL values.
@mhilton mhilton requested a review from a team as a code owner June 12, 2024 17:03
@mhilton mhilton merged commit 6412246 into master Jun 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants