test(parser): parse time literals #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added test case to check that time literals are parsed as midnight on that date
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
- Coverage 55.57% 55.55% -0.02%
==========================================
Files 211 211
Lines 30288 30288
==========================================
- Hits 16832 16828 -4
+ Misses 11770 11769 -1
- Partials 1686 1691 +5
Continue to review full report at Codecov.
|
ghost
requested review from
davidgs
pushed a commit
to davidgs/flux
that referenced
this pull request
Aug 20, 2019
- added test case to check that time literals are parsed as midnight on that date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test case to check that time literals are parsed as midnight on that date
(see #152)