refactor(stdlib): rename percentile to quantile and implement percent… #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
reviewed
Mar 28, 2019
docs/SPEC.md
Outdated
| @@ -1592,10 +1592,10 @@ Median is defined as: | |||
|
|
|||
| median = (method="estimate_tdigest", compression=0.0, tables=<-) => | |||
| tables | |||
| |> percentile(percentile:0.5, method:method, compression:compression) | |||
| |> quantile(quantile:0.5, method:method, compression:compression) | |||
There was a problem hiding this comment.
Below the argument is defined as q not quantile.
|
@nathanielc I think it's probably unnecessary, even though I put up the PR :) . They're exactly the same function, their arguments are just at different scales. I think I prefer to have just one way to perform a quantile calculation. I don't see it as a huge mental burden to switch between a [0, 1] scale vs [0, 100]. |
|
OK, in that case should we just rename it to |
|
I would prefer it called quantile, especially if we are using values between 0 and 1. Currently it's a little inconsistent. But we don't need both functions. |
nathanielc
approved these changes
Mar 29, 2019
BREAKING CHANGE: Rename the percentile function to quantile and rename the percentile parameter to q. Fixes #1072.
jpacik
force-pushed
the
refactor/rename-percentile
branch
from
e3925f0 to
445a2cf
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ile in terms of quantile
BREAKING CHANGE: Rename the percentile function to quantile. Also rename the percentile
parameter to q. Also implement a new percentile function that takes a parameter p that
is an integer between 0 and 100 inclusive. The new percentile function is defined in
terms of quantile.
Fixes #1072.
Done checklist