-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix y-axis graph padding #882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good to me. Also checked out the branch and everything seems to be in order. Only thing missing is some tests. Specifically for the bug that's being fixed.
Cool, thanks! Getting to tests now and will come back with something. |
@121watts I added a couple of preliminary tests for your perusal. Questions: |
@jaredscheib Once you update the CHANGELOG this is good to merge! |
Cool, done! |
Connect #881
The problem
Graph did not properly display highlighted range when value for "greater than" rule exceeded local data peak value. This bug also showed up in "inside range" and "outside range".
The Solution
Fixed display for "greater than":