Update kapacitor alert rule to have detail field #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoquick
reviewed
Feb 8, 2017
| @@ -34,19 +30,19 @@ export const RuleMessage = React.createClass({ | |||
| const alerts = this.props.enabledAlerts.map((text) => { | |||
| return {text, ruleID: rule.id}; | |||
| }); | |||
| const selectedAlert = rule.alerts[0]; | |||
There was a problem hiding this comment.
Should this always be the first item in the array? Why is that?
There was a problem hiding this comment.
it should either be the first element in the array or undefined. Currently, there is only a 1-to-1 relationship of rule to output. This will be changing in the future which is why it's stored in an array.
| return {...state, ...{ | ||
| [ruleID]: {...state[ruleID], details}, | ||
| }}; | ||
| } |
There was a problem hiding this comment.
haha. idk if this syntax is easier to follow than Object.assign but I'm trying it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #838
The problem
Kapacitor supports adding an email body via the
.details()chaining method.The Solution
Added
detailto rules endpoint.