Simplify DataExplorer #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
force-pushed
the
de-struction
branch
from
9404070 to
68ec7df
Compare
121watts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #822
The problem
The idea of sessions or
explorationsin theDataExplorerincreased app complexity greatly and provided little to no value.Removing the concept of explorations also removes DE persistence from the server.
The Solution
Remove the concept of
ExplorationsInstead we will treat the DE state much like we do the
TimeRange. Namely savingqueriesandpanelsinlocalStorage. Additionally, I added some precedence for saving UI state in a reducer. So, if a user refreshes the page, the last panel they were using will remain openNotable areas of code
Most of this PR is the removal of code. Yay! The notable / additive parts can be located here:
https://github.com/influxdata/chronograf/pull/841/files#diff-efb9100985b5e1f2631ed1303a78e7d1R1
https://github.com/influxdata/chronograf/pull/841/files#diff-b716d6946190fdf957d34b618570e8a2R1
https://github.com/influxdata/chronograf/pull/841/files#diff-efb9100985b5e1f2631ed1303a78e7d1R1