Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): upgrade golang to 1.18.4 #5990

Merged
merged 2 commits into from
Jul 22, 2022
Merged

chore(build): upgrade golang to 1.18.4 #5990

merged 2 commits into from
Jul 22, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jul 20, 2022 •
edited
Loading

Closes #5989

This PR upgrades golang to 1.18.4

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • Any changes to etc/Dockerfile_build have been pushed to DockerHub, and the changes have been added to .circleci/config.yml

@sranka
Copy link
Contributor Author

sranka commented Jul 20, 2022

@ivankudibal this PR requires a new build image to be ready for review - https://github.com/influxdata/chronograf/blob/master/etc/README.md

@sranka sranka requested a review from ivankudibal July 20, 2022 06:28
@ivankudibal
Copy link
Contributor

ivankudibal commented Jul 21, 2022 •
edited
Loading

[✔] Step 1: Build New Docker Image and Save It to Quay

chronograf-20220721: digest: sha256:aaa86c015ef521b4d835cd51b3a0222f4f39e4e4b2a82ee1d30b3f7c6f85b8a3 size: 2007

@sranka sranka self-assigned this Jul 21, 2022
@sranka sranka marked this pull request as ready for review July 21, 2022 19:17
@sranka
Copy link
Contributor Author

sranka commented Jul 21, 2022

[heavy_check_mark] Step 1: Build New Docker Image and Save It to Quay

chronograf-20220721: digest: sha256:aaa86c015ef521b4d835cd51b3a0222f4f39e4e4b2a82ee1d30b3f7c6f85b8a3 size: 2007

New builder image applied, thx, please review & approve

ivankudibal
ivankudibal approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@ivankudibal ivankudibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@sranka sranka merged commit fcf2c52 into master Jul 22, 2022
@sranka sranka deleted the 5989/go_1.18.4 branch July 22, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankudibal ivankudibal ivankudibal approved these changes

Assignees

@sranka sranka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please upgrade golang to 1.18.4 for security fixes
2 participants
@sranka @ivankudibal