Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add InfluxDB admin tabs to user/role detail page #5956

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 23, 2022

Closes #5953

Main administration tabs (Databases, Users, Roles, Queries) are added to User/Role detail page in this PR. Additionally, Apply Changes takes the user to the list of user/roles upon success.

image
image

When a tab is clicked and there are unsaved changes on the detail page, the user has to confirm that these changes will be discarded.
image

@sranka sranka requested a review from samhld June 23, 2022 09:25
@sranka sranka marked this pull request as ready for review June 23, 2022 09:37
@sranka sranka requested a review from k3yi0 June 23, 2022 09:42
Copy link

@samhld samhld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only nitpick I have left (very minor) is that I think when you "Apply Changes", it should take you back to the "home" of the tab you were in. Right now, the user has to know to re-click the tab to go back there..

@sranka sranka force-pushed the 5953/keep_tabs_in_detail_pages branch from 4301eb4 to 8c6b0d0 Compare June 24, 2022 04:07
@sranka sranka force-pushed the 5953/keep_tabs_in_detail_pages branch from a17a082 to 34378c6 Compare June 24, 2022 05:42
@sranka sranka merged commit 38ee6bb into master Jun 24, 2022
@sranka sranka deleted the 5953/keep_tabs_in_detail_pages branch June 24, 2022 08:11
@sranka
Copy link
Contributor Author

sranka commented Jun 24, 2022

LGTM! The only nitpick I have left (very minor) is that I think when you "Apply Changes", it should take you back to the "home" of the tab you were in. Right now, the user has to know to re-click the tab to go back there..

Apply Changes now takes the user to the roles/users page.

@sranka sranka added this to the 1.10 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show top level tabs in InfluxDB User/Role detail page
3 participants