Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): improve InfluxDB role creation #5926

Merged
merged 14 commits into from
Jun 8, 2022
Merged

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 7, 2022

This PR is a part of the solution to #5834. It improves the way how new InfluxDB roles are created.

image

  • a confirmation dialog asking for a role name is shown after clicking Create Role; A role detail page appears right after the new role is created
  • error notifications are shown when a role name is too short, or the same role already exists
  • the code is simplified to remove useless redux state management
  • a few minor bugs are fixed herein as well
  • create dialogs (for both user and role) now visually distinguish valid inputs

@sranka sranka changed the title Feat/influxdb new create role feat(ui): improve InfluxDB role creation Jun 7, 2022
@sranka sranka requested review from k3yi0 and ivankudibal June 7, 2022 13:52
@sranka sranka marked this pull request as ready for review June 7, 2022 13:52
@sranka sranka force-pushed the feat/influxdb_new_create_role branch from 63dd438 to b93a41a Compare June 7, 2022 14:02
@sranka sranka merged commit cd10b61 into master Jun 8, 2022
@sranka sranka deleted the feat/influxdb_new_create_role branch June 8, 2022 06:28
@sranka sranka added this to the 1.10 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants