Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): improve InfluxDB user creation #5925

Merged
merged 18 commits into from
Jun 7, 2022
Merged

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 6, 2022

This PR is a part of the solution to #5834. It improves the way how new InfluxDB users are created.

image

  • a confirmation dialog asking for user name and password is shown after clicking Create User, user detail page allowing to setup roles and DB permissions appears after the new user is created
  • error notifications are shown when a user name is too short, a password is too short, or the same user name already exists
  • the code is simplified to remove useless redux state management
  • a few minor bugs are fixed herein as well

@sranka
Copy link
Contributor Author

sranka commented Jun 6, 2022

@k3yi0 can you please adjust e2e tests to adopt the new implementation

@sranka sranka requested a review from k3yi0 June 7, 2022 12:02
@sranka sranka marked this pull request as ready for review June 7, 2022 12:02
@sranka sranka merged commit d7b4052 into master Jun 7, 2022
@sranka sranka deleted the feat/influxdb_new_create_user branch June 7, 2022 13:24
@sranka sranka requested a review from ivankudibal June 7, 2022 13:38
@sranka sranka added this to the 1.10 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants