Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add TICKscripts page #5871

Merged
merged 36 commits into from
Mar 1, 2022
Merged

feat(ui): add TICKscripts page #5871

merged 36 commits into from
Mar 1, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Feb 22, 2022

This PR adds a UI page that contains only TICKscripts.

  • there is a new TICKscripts menu item in the navigation sidebar, it goes a new TICKscripts page
    image
  • the page shows a list of TICKscripts of a selected kapacitor, the list the same as on the existing Alert Rules page, it can be filtered by alert rule name
    image
  • at most 100 kapacitor rules are fetched from kapacitor when the page is initially opened, the user is informed if the list is truncated and can proceed to load all items. This filter-less operation is quite quick since it loads just 100 rules from kapacitor.
  • when a filter is supplied, all rules must be fetched from kapacitor (which takes much longer time that fetching 100) in order to filter by alert rule name
  • the list of TICKscripts is paginated when more than 100 items are shown, changing a page take the user to the top of the list
    image
  • unlike the existing Alert Rules page, the TICKscripts page shows just TICKscripts. It is then much quicker because chronograf does not need to parse every TICKscript to see if it is a rule that is compatible with Alert Rule Builder. More details are explained in #5460
  • the edit/create TICKscript page is opened with l=t query parameter, so that its Exit returns back to the TICKscripts page (would be Alert Rules otherwise).

This PR is a part of a solution to #5460.

@sranka sranka marked this pull request as ready for review February 24, 2022 18:16
@sranka sranka requested a review from ivankudibal February 24, 2022 18:24
@sranka sranka merged commit 7174fde into master Mar 1, 2022
@sranka sranka deleted the feat/tickscripts_page branch March 1, 2022 19:40
@ivankudibal ivankudibal added this to the 1.9.4 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants