Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): optimize Alert Rules API #5869

Merged
merged 14 commits into from
Feb 22, 2022
Merged

feat(server): optimize Alert Rules API #5869

merged 14 commits into from
Feb 22, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Feb 21, 2022

This PR enhances API that returns Alert Rules so that the UI can better and quickly respond. This PR is a part of a solution to #5460, the API now supports

  • limit query parameter that can limit the result size and thus reduce the time that is spent during analysis of TICKscripts
  • pattern query parameter that can filter alert rules to have a specific string value in alert rule names
  • parse query parameter can turn off TICKScript parsing when set to 0 so that just TICKScipts can be returned much quicker

Tests were enhanced and swagger updated.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • swagger.json updated (if modified Go structs or API)

@sranka sranka changed the title feat(ui): optimize Alert Rules API feat(server): optimize Alert Rules API Feb 22, 2022
@sranka sranka added this to the 1.9.4 milestone Feb 22, 2022
@sranka sranka requested a review from ivankudibal February 22, 2022 05:39
@sranka sranka marked this pull request as ready for review February 22, 2022 05:40
@sranka sranka force-pushed the 5460/list_rules_params branch from e2532c7 to 8050e36 Compare February 22, 2022 13:56
@sranka sranka merged commit 72ee515 into master Feb 22, 2022
@sranka sranka deleted the 5460/list_rules_params branch February 22, 2022 14:14
@ivankudibal ivankudibal removed their request for review March 22, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants