-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): optimize Alert Rules API #5869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
changed the title
feat(ui): optimize Alert Rules API
feat(server): optimize Alert Rules API
Feb 22, 2022
vlastahajek
approved these changes
Feb 22, 2022
sranka
force-pushed
the
5460/list_rules_params
branch
from
February 22, 2022 13:56
e2532c7
to
8050e36
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances API that returns Alert Rules so that the UI can better and quickly respond. This PR is a part of a solution to #5460, the API now supports
limit
query parameter that can limit the result size and thus reduce the time that is spent during analysis of TICKscriptspattern
query parameter that can filter alert rules to have a specific string value in alert rule namesparse
query parameter can turn off TICKScript parsing when set to0
so that just TICKScipts can be returned much quickerTests were enhanced and swagger updated.