Fix ceo visualization not using ceo time range for query #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
fix/ceo-time-range
branch
from
7ff5900 to
cd8db96
Compare
AlirieGray
reviewed
Apr 16, 2019
| TEMP_VAR_UPPER_DASHBOARD_TIME, | ||
| } from 'src/shared/constants' | ||
|
|
||
| export const createTimeRangeTemplates = ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5134
Briefly describe your proposed changes:
What was the problem?
The correct time range was being used for the dropdown in the ceo but the templates used to render the template variables in the query were that of the Dashboard and not relevant to the time in the ceo.
What was the solution?
The templates in the ceo should be the dashboard's templates and dashboardTime template variables created from the ceo's time range.