fix(logs): fix log color utils #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfTheDelmer
added a commit
that referenced
this pull request
Jan 10, 2019
* fix(logs): fix log color utils
afausti
added a commit
to lsst-sqre/chronograf
that referenced
this pull request
Mar 13, 2019
* upstream/master: (40 commits) Update chronograf version number Fixed the fromCSV function Fixed the window function (influxdata#5083) Fixed versions and links in readme (influxdata#5063) Fix error when editing kapacitor info in onboarding fix: active kapacitor updating and ui defaults (influxdata#5079) Be less aggressive on windowInterval Stop cells with raw/no format selected from getting changed to base 10 fix(ui): fix decimalPlaces with wrapper (influxdata#5073) Escape injected meta query values Update changelog for 1.7.7 Use JWT in enterprise for authentication Fix meta query group calls Update flux to 0.12 to match influxdb updating functions for flux 0.12 (influxdata#5035) Update hostname for meta urls for new sources only fix: update chronograf version to 1.7.6 Bugfix/threshold (influxdata#4916) fix(logs): fix log color utils (influxdata#4909) Set kapacitor state in ConnectionWizard and call syncHostnames for new kapacitors ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4862
Briefly describe your proposed changes:
Extract a util for
brighteninga color that guards against undefined colorValues. Similarly, update the color scale to go fromseverity=>default_severity_color_name=>default_severity_color_value.What was the problem?
It's unclear what the root cause of 4862 is. However, 4862 includes an error message regarding an attempt to brighten an undefined colorValue that could be fixed.
What was the solution?
Fix the
colorScalereturning acolorNameinstead of a color hex value when given just a severity level. Extract a color util that adds a guard againstd3-colortrying to brighten an undefined color value.