Fix logs loading newer #4814
Merged
Fix logs loading newer #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
approved these changes
Nov 14, 2018
OfTheDelmer
force-pushed
the
fix/loading-newer-scrollbar
branch
from
6aef2ae to
bac584b
Compare
OfTheDelmer
added a commit
that referenced
this pull request
Nov 14, 2018
Fix logs loading newer scroll * Fix logs loading newer * Update changelog 1.7.4 bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/influxdata/applications-team-issues/issues/267
Briefly describe your proposed changes:
Makes
isLoadingNewerpart of theLogsPagestate so the table will be re-rendered once the logs table has finished loading newer rows. This fixes a race condition where scrolling to the top of the logs table could cause scroll position to get stuck if the user did not scroll while new rows were being added.What was the problem?
Scroll position could get stuck because the update that signaled loading newer had completed was not causing the table to be rendered
What was the solution?
Move
isLoadingNewerinto theLogsPagestate and update state once a fetch for newer data has completed.