fix(db-admin): only handle db state on db create #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredscheib
approved these changes
Nov 12, 2018
|
Sounds & looks good to me |
OfTheDelmer
pushed a commit
that referenced
this pull request
Dec 12, 2018
OfTheDelmer
pushed a commit
that referenced
this pull request
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4801
Briefly describe your proposed changes:
When creating a new database, the UI is a bit confusing. There are two "save" buttons (one for the DB and one for the RP). I have decided to have the "create DB" ui exclusively create a database and a default retention policy. Should a user want to add / manipulate the default retention policy after creation.
What was the problem?
When the user hits "save" on an RP whose database has not yet been created we get various runtime errors.
Before
After