Change PagerDuty2 service-key to routing-key
#3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredscheib
changed the title
service-key to routing-key
ischolten
reviewed
May 14, 2018
|
|
||
| private handleRoutingKeyRef = r => (this.routingKey = r) | ||
|
|
||
| private handleEnabledChange = (e: ChangeEvent<HTMLInputElement>) => { |
There was a problem hiding this comment.
Consider typing the return as void
There was a problem hiding this comment.
good catch. just copied all of this -- will type :)
ischolten
reviewed
May 14, 2018
| this.disableTest() | ||
| } | ||
|
|
||
| private handleSubmit = async e => { |
There was a problem hiding this comment.
consider typing function signature
ischolten
reviewed
May 14, 2018
| private handleSubmit = async e => { | ||
| e.preventDefault() | ||
|
|
||
| const properties = { |
There was a problem hiding this comment.
This would be type Properties
ischolten
reviewed
May 14, 2018
| onGoToConfig, | ||
| validationError, | ||
| }) => | ||
| selectedHandler.enabled ? ( |
There was a problem hiding this comment.
Consider changing this to not use a ternary
ischolten
reviewed
May 14, 2018
| <span className="icon cog-thick" /> | ||
| {validationError | ||
| ? 'Exit this Rule and Edit Configuration' | ||
| : 'Save this Rule and Edit Configuration'} |
ischolten
approved these changes
May 14, 2018
jaredscheib
force-pushed
the
fix/pagerdutyv2_servicekey
branch
from
f6a46c6
to
13b6bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2786
What was the problem?
PagerDuty v2's integration key is
routing-key, notservice-key.What was the solution?
Create separate, dedicated PagerDuty2 config & handler components with the correct
routing-keyfield name and UI copy.