Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple loading spinner to Alert History page. #1130

Merged
merged 4 commits into from
Mar 30, 2017
Merged

Add simple loading spinner to Alert History page. #1130

merged 4 commits into from
Mar 30, 2017

Conversation

cryptoquick
Copy link
Contributor

@cryptoquick cryptoquick commented Mar 30, 2017 •
edited
Loading

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #1054

The problem

The Alert History page does not show a spinner when the data is loading.

The Solution

Add a spinner to the component.

@nhaugo nhaugo requested a review from timraymond March 30, 2017 16:16
@cryptoquick cryptoquick requested a review from 121watts March 30, 2017 16:20
121watts
121watts approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredscheib
Copy link
Contributor

@cryptoquick be sure to increment the item number on your changelog updates, i.e. 1. [#1130](... -- looks like there are actually 3x 1.s now

@cryptoquick
Copy link
Contributor Author

cryptoquick commented Mar 30, 2017 •
edited
Loading

@jaredscheib no
learn markdown pls

timraymond
timraymond approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cryptoquick cryptoquick merged commit 317123e into master Mar 30, 2017
@cryptoquick cryptoquick deleted the feature/1054-alert-history-spinner branch March 30, 2017 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@timraymond timraymond timraymond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cryptoquick @jaredscheib @timraymond @121watts