Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compression for InfluxQL query responses #1101

Merged
merged 4 commits into from
Mar 28, 2017
Merged

Add compression for InfluxQL query responses #1101

merged 4 commits into from
Mar 28, 2017

Conversation

goller
Copy link
Contributor

@goller goller commented Mar 28, 2017 •
edited
Loading

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #

The problem

InfluxQL responses can be massive. Gzip compression seems to work well against InfluxQL.

The Solution

Added compression for all InfluxQL responses. This should help in the speed of the data responses.

@goller goller requested a review from timraymond March 28, 2017 19:40
timraymond
timraymond approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! ✨

@cryptoquick cryptoquick self-requested a review March 28, 2017 22:18
cryptoquick
cryptoquick reviewed Mar 28, 2017
View reviewed changes
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I see gzipped responses from this endpoint being decoded by my browser quite nicely. this should be a good improvement.

@cryptoquick
Merge commit '52e70c77ff11c4af69bb166c65d9e359454d819e' into feature/…
c9b29ff 
…gzipped-influx-responses

# Conflicts:
#	CHANGELOG.md
@cryptoquick cryptoquick merged commit d202897 into master Mar 28, 2017
@cryptoquick cryptoquick deleted the feature/gzipped-influx-responses branch March 28, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevmorris lukevmorris lukevmorris approved these changes

@timraymond timraymond timraymond approved these changes

@cryptoquick cryptoquick cryptoquick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goller @cryptoquick @timraymond @lukevmorris