WIP: apply upstream commit for "enable parallelized writes with ParquetSink" #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what I did on this branch:
git checkout main
git co -b chunchun/denise-df-11 671cef85c550969ab2c86d644968a048cb181c0c
git cherry-pick 9c8873af12826e47f5743991859790df7a3b6400 |
appletreeisyellow
force-pushed
the
chunchun/denise-df-11
branch
from
50774b9
to
671cef8
Compare
* chore: make explicit what ParquetWriterOptions are created from a subset of TableParquetOptions * refactor: restore the ability to add kv metadata into the generated file sink * test: demomnstrate API contract for metadata TableParquetOptions * chore: update code docs * fix: parse on proper delimiter, and improve tests * fix: enable any character in the metadata string value, by having any key parsing be a part of the format.metadata::key
|
Current main is up to this April 26th commit: c9bd291 The current main includes the merged upstream PR (for the parquet sink metadata change). So no cherry-pick is needed! 🎉 
|
appletreeisyellow
changed the title
|
Closing as the update was done without issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on apache@671cef8 which was merged to DataFusion on April 13, 2024.
All the patches in the previous temporary dependency branch (WIP(iox-10577): patched df upgrade 202-04-14) are caught up at the end of April 13 commit (apache@671cef8), so creating a new branch for @wiedld's "enable parallelized writes with ParquetSink" work, which an upstream PR (apache#10224 / apache@9c8873a) is cherry-picked on this branch
ParquetSinkapache/datafusion#10224 / apache@9c8873a