-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: openssl partial CA trust anchor #2232
Closed
pinkforest
wants to merge
11
commits into
infinyon:master
from
pinkforest:feat-openssl-trust-anchor-ca-partial
Closed
[Merged by Bors] - feat: openssl partial CA trust anchor #2232
pinkforest
wants to merge
11
commits into
infinyon:master
from
pinkforest:feat-openssl-trust-anchor-ca-partial
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
changed the title
[WIP] feat: openssl partial CA trust anchor
feat: openssl partial CA trust anchor
Mar 2, 2022
Can you link to issue? |
bors bot
pushed a commit
to infinyon/future-aio
that referenced
this pull request
Mar 7, 2022
Closes #135 This proposed feature adds to TlsClient constructor: - `allow_partial: bool` which toggles OpenSSL [X509VerifyFlags::PARTIAL_CHAIN](https://docs.rs/openssl/latest/openssl/x509/verify/struct.X509VerifyFlags.html#associatedconstant.PARTIAL_CHAIN) - default `true` ### Publish This PR bumps fluvio-futures to 0.3.14 Enables bump in k8-client: - infinyon/k8-api#151 Which in turn enables bump in fluvio: - infinyon/fluvio#2232
bors bot
pushed a commit
to infinyon/k8-api
that referenced
this pull request
Mar 7, 2022
Related to infinyon/fluvio#2232 ### Dependant on fluvio-future bump to 0.3.14 under; - infinyon/future-aio#134 ### Publish This PR bumps k8-client to 0.5.1 Which in turn enables bump in fluvio: infinyon/fluvio#2232
sehz
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Fixes #2216 by adopting downstream changes from fluvio-future & k8-client Intermediate CAs are used to compartmentalize issuance and management in certain configurations to improve security. However managing the full client CA chain in this case would become logistically cumbersome and the industry has moved to generally to accept using the intermediate CAs as the partial "Trust anchor" on the client end e.g. curl or kubectl. ### Dependant on fluvio-future bump to 0.3.14 under: - infinyon/future-aio#134 k8-client bump to 0.5.1 (depends fluvio-future 0.13.14 as well) - infinyon/k8-api#151
Build failed: |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Fixes #2216 by adopting downstream changes from fluvio-future & k8-client Intermediate CAs are used to compartmentalize issuance and management in certain configurations to improve security. However managing the full client CA chain in this case would become logistically cumbersome and the industry has moved to generally to accept using the intermediate CAs as the partial "Trust anchor" on the client end e.g. curl or kubectl. ### Dependant on fluvio-future bump to 0.3.14 under: - infinyon/future-aio#134 k8-client bump to 0.5.1 (depends fluvio-future 0.13.14 as well) - infinyon/k8-api#151
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat: openssl partial CA trust anchor
[Merged by Bors] - feat: openssl partial CA trust anchor
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2216 by adopting downstream changes from fluvio-future & k8-client
Intermediate CAs are used to compartmentalize issuance and management in certain configurations to improve security.
However managing the full client CA chain in this case would become logistically cumbersome and the industry has moved to generally to accept using the intermediate CAs as the partial "Trust anchor" on the client end e.g. curl or kubectl.
Dependant on
fluvio-future bump to 0.3.14 under:
k8-client bump to 0.5.1 (depends fluvio-future 0.13.14 as well)