Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple from Rails secrets #4

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Decouple from Rails secrets #4

merged 9 commits into from
Jun 12, 2024

Conversation

vr4b4c
Copy link
Member

@vr4b4c vr4b4c commented May 24, 2024

Task: #78

Aim

Remove dependency on Rails secrets and let clients choose how to manage secret parameters.

Initialization

Devise omniauth initialization procedure is moved from Rails initializer to Railtie initializer because it supports more granular control over initialization order. Rails config initializer for dependencies runs before host applications config initializers. This is a problem because Devise omniauth is configured before the host can set infinum_azure configuration options (eg. load params from configuration and/or secret stores). infinum_azure initialization should run after the host application config initializer and before devise.omniauth initializer, which can be expressed via the Raitie initializer.

Fixes #3

Solution

  • Remove dependency on Rails secrets
  • Remove Defaults module and refactor Config
  • Remove service_name property (not used)
  • Update README and CHANGELOG

@vr4b4c vr4b4c self-assigned this May 24, 2024
README.md Outdated Show resolved Hide resolved
@vr4b4c vr4b4c force-pushed the feature/replace-secrets branch 2 times, most recently from 1881ec3 to ba324e4 Compare June 8, 2024 10:27
@vr4b4c vr4b4c force-pushed the feature/replace-secrets branch from ba324e4 to 370ffd6 Compare June 12, 2024 08:08
@vr4b4c vr4b4c merged commit d709bf3 into master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret provider
2 participants