Make propertyClass mandatory in HasOne decorator

infinum · Apr 24, 2023 · 7348ea0 · 7348ea0
1 parent f55b56b
commit 7348ea0
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/projects/ngx-hal/src/lib/decorators/has-one.decorator.ts b/projects/ngx-hal/src/lib/decorators/has-one.decorator.ts
@@ -6,7 +6,7 @@ import { HasOneModelProperty } from '../interfaces/model-property.interface';
 import { HalModel } from '../models/hal.model';
 import { deepmergeWrapper } from '../utils/deepmerge-wrapper';
 
-export function HasOne(options: HasOneOptions = {}) {
+export function HasOne(options: HasOneOptions) {
 	return (model: HalModel, propertyName: string) => {
 		const hasOneOptions: HasOneOptions = deepmergeWrapper(DEFAULT_HAS_ONE_OPTIONS, options);
 

diff --git a/projects/ngx-hal/src/lib/interfaces/attribute-options.interface.ts b/projects/ngx-hal/src/lib/interfaces/attribute-options.interface.ts
@@ -1,7 +1,7 @@
 import { ModelConstructor, ModelConstructorFn } from '../types/model-constructor.type';
 
 export interface AttributeOptions {
-	useClass?: boolean | string | ModelConstructor<any> | ModelConstructorFn<any>;
+	useClass?: string | ModelConstructor<any> | ModelConstructorFn<any>;
 	transformResponseValue?: (rawAttribute: any) => any;
 	transformBeforeSave?: (raw: any) => any;
 	externalName?: string;

diff --git a/projects/ngx-hal/src/lib/interfaces/has-one-options.interface.ts b/projects/ngx-hal/src/lib/interfaces/has-one-options.interface.ts
@@ -3,7 +3,7 @@ import { ModelConstructor, ModelConstructorFn } from '../types/model-constructor
 export interface HasOneOptions {
 	externalName?: string;
 	includeInPayload?: boolean;
-	propertyClass?: string | ModelConstructor<any> | ModelConstructorFn<any>;
+	propertyClass: string | ModelConstructor<any> | ModelConstructorFn<any>;
 }
 
 export const DEFAULT_HAS_ONE_OPTIONS = {

diff --git a/projects/ngx-hal/src/lib/mocks/car.mock.model.ts b/projects/ngx-hal/src/lib/mocks/car.mock.model.ts
@@ -16,6 +16,7 @@ export class CarModel extends HalModel {
 	carName: string;
 
 	@HasOne({
+		propertyClass: MockModel2,
 		includeInPayload: true,
 		externalName: 'parentCompany',
 	})

diff --git a/projects/ngx-hal/src/lib/mocks/mock-model-templated.ts b/projects/ngx-hal/src/lib/mocks/mock-model-templated.ts
@@ -17,6 +17,7 @@ export class MockTemplatedModel extends HalModel {
 	prop1: string;
 
 	@HasOne({
+		propertyClass: MockModel2,
 		includeInPayload: true,
 	})
 	mockModel2Connection: MockModel2;