Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce better naming convention #45

Closed
wants to merge 35 commits into from
Closed

Enforce better naming convention #45

wants to merge 35 commits into from

Conversation

isBatak
Copy link
Contributor

@isBatak isBatak commented Nov 24, 2021

Solves #42 and #44

What's the best way to test these changes?
This issue #42 (comment) may still exist.

Todo

@fvoska
Copy link
Contributor

fvoska commented Nov 24, 2021

To test the changes, it is best to create an example project that uses the config and write some code that would trigger linting errors/warnings. That is how we did it for Angular-specific eslint config here and we could probably do the same for the base TS config with some simple TS example project

@fvoska
Copy link
Contributor

fvoska commented Nov 24, 2021

As for the issue from the comment #42 (comment), I had the same issue on some angular repo where I added some 3rd party rule that require TS compiler and there I also had to define parserOptions.project (https://github.com/infinum/ngx-nuts-and-bolts/blob/main/libs/ngx-nuts-and-bolts/.eslintrc.json#L8). I think this is something that will have to be done in each project individually because the tsconfig file that we have to point to might be in a different location or named differently.

We should update the readme with this info.

@kristijanbambir
Copy link
Contributor

Is this PR done or is there more work to be done? If it's not done, please convert it to a draft until completed.

@isBatak isBatak requested a review from fvoska December 3, 2021 22:39
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Ivica Batinic added 3 commits December 10, 2021 13:05
* WIP on tests

* Finish testing utils

* Remove eslint-config-rule-tester

* Revert nextjs example
@isBatak isBatak requested a review from adrianbicanic as a code owner June 2, 2022 11:59
@isBatak isBatak marked this pull request as draft July 14, 2022 11:06
@adrianbicanic
Copy link
Contributor

adrianbicanic commented Nov 30, 2022

@isBatak Any updates or info related to this PR?

@isBatak
Copy link
Contributor Author

isBatak commented Dec 1, 2022

@adrianbicanic I have to revisit this PR and add tests

@isBatak isBatak force-pushed the naming-convention branch from 70265bc to b8ab234 Compare March 10, 2023 16:07
@isBatak isBatak force-pushed the naming-convention branch from b8ab234 to 34e1a0e Compare March 10, 2023 16:08
@isBatak isBatak force-pushed the naming-convention branch from bdbbb8f to 0c2c931 Compare March 10, 2023 16:14
@isBatak isBatak marked this pull request as ready for review March 10, 2023 16:55
@isBatak isBatak requested a review from kristijanbambir March 10, 2023 16:57
@isBatak
Copy link
Contributor Author

isBatak commented Mar 10, 2023

@adrianbicanic it's ready!

@isBatak isBatak requested review from thabalija and removed request for kristijanbambir March 13, 2023 12:50
@kamdubiel
Copy link
Contributor

Done in:
#128

@kamdubiel kamdubiel closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants