-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce better naming convention #45
Conversation
To test the changes, it is best to create an example project that uses the config and write some code that would trigger linting errors/warnings. That is how we did it for Angular-specific eslint config here and we could probably do the same for the base TS config with some simple TS example project |
As for the issue from the comment #42 (comment), I had the same issue on some angular repo where I added some 3rd party rule that require TS compiler and there I also had to define We should update the readme with this info. |
Is this PR done or is there more work to be done? If it's not done, please convert it to a draft until completed. |
* WIP on tests * Finish testing utils * Remove eslint-config-rule-tester * Revert nextjs example
@isBatak Any updates or info related to this PR? |
@adrianbicanic I have to revisit this PR and add tests |
70265bc
to
b8ab234
Compare
b8ab234
to
34e1a0e
Compare
bdbbb8f
to
0c2c931
Compare
@adrianbicanic it's ready! |
Done in: |
Solves #42 and #44
What's the best way to test these changes?
This issue #42 (comment) may still exist.
Todo