Cleanup #248
Merged
Cleanup #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iruzevic
previously approved these changes
Jan 28, 2021
goranalkovic-infinum
previously approved these changes
Jan 29, 2021
iruzevic
previously approved these changes
Jan 29, 2021
kmaric69
reviewed
Jan 30, 2021
kmaric69
reviewed
Jan 30, 2021
|
Left some minor comments. Rest looks good...nice job! |
kmaric69
previously approved these changes
Jan 30, 2021
dingo-d
dismissed stale reviews from kmaric69, iruzevic, and goranalkovic-infinum
via
01f6bae
dingo-d
requested review from
kmaric69,
goranalkovic-infinum,
iruzevic and
a team
iruzevic
previously approved these changes
Jan 31, 2021
gabriel-glo
previously approved these changes
Feb 1, 2021
MetarDev
reviewed
Feb 1, 2021
MetarDev
reviewed
Feb 1, 2021
MetarDev
reviewed
Feb 1, 2021
MetarDev
reviewed
Feb 1, 2021
MetarDev
reviewed
Feb 1, 2021
MetarDev
previously approved these changes
Feb 1, 2021
MetarDev
previously approved these changes
Feb 2, 2021
Will be added automatically if the image is imported from wp and has the alt tag added. Props @JerrySpecter. Co-authored-by: Karlo Biscan <JerrySpecter@users.noreply.github.com>
Fix the visibility toggle.
gabriel-glo
previously approved these changes
Feb 2, 2021
goranalkovic-infinum
requested changes
Feb 2, 2021
iruzevic
requested changes
Feb 2, 2021
iruzevic
requested changes
Feb 2, 2021
goranalkovic-infinum
previously approved these changes
Feb 2, 2021
kmaric69
previously approved these changes
Feb 2, 2021
|
Hmmm, so I need to find a way to update the meta field for the alt when changed in the options 🤔 on my way! EDIT: Turns out that's how the core image is also behaving. Odd... I've opened up a bug, but maybe it's a feature, not a bug 👀 |
Alt description can be larger text, so it makes sense to have textarea.
dingo-d
dismissed stale reviews from kmaric69, goranalkovic-infinum, and gabriel-glo
via
ba316dd
iruzevic
requested changes
Feb 2, 2021
blocks/init/src/Blocks/components/image/components/image-options.js
Outdated
Show resolved
Hide resolved
iruzevic
approved these changes
Feb 2, 2021
dingo-d
requested review from
kmaric69,
goranalkovic-infinum,
gabriel-glo and
a team
goranalkovic-infinum
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done the cleanup inspection for the scripts part of the frontend libs.
There are lots of minor fixes. The easiest way to look at this PR is to go through the commits when reviewing to see what has been changed, and to understand the reason for the fixes.