Swift6 migration #23
Open
Swift6 migration #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the library to Swift6.
The PR consist of 4 commits:
await fulfillmentinstead ofwaitForExpectationssince waitForExpectations has @mainactor annotation.Anyas associated value from HalleyKit.Error since Any does not conform to sendable.The last change is probably not what we want since it is beneficial to provide some sort of
Datathat can be logged by the users of this library in case an error occurs at some point. My idea would be to useDataas associated value instead of Any if possible but I would like to hear other options if there are any before doing this.