This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
fix strange ejs file #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thats a pretty big blame graphic Gant. 🤣 Is that from the PR where I copied everything over from the previous repo? I think @jamonholmgren wrote the App.Config piece. Jamon do you remember if we had props in that template at all? It seems like we don't need that anymore? |
|
copy/paste from my laptop made it YUGE! If we both see no purpose, I declare it dead. |
|
The ejs file is I believe from before we had the i18n plugin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming this was just a logic error in passing, but wanted to verify before merging.
Generated projects would end up with an regular file and an ejs file of the same thing. I don't see any ejs logic, so just short-circuiting it here.