This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Fix generate listview with parameter #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #11 |
|
awesome! Thanks so much. Do you know if there's any place in the docs that should have been updated as well? This is the problem with playing catchup on docs 💃 |
|
There was no change in behavior so I did not think to look, but I'll take a look tomorrow morning.
On Apr 4, 2017, at 4:09 PM, Gant Laborde <notifications@github.com<mailto:notifications@github.com>> wrote:
Merged #12<#12>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#12 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGinBxrYXo0NKAqsKcmTorWW3nvQcogjks5rsk8JgaJpZM4Mys9X>.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
ignite g listview TestRow --type=Rowfails with an exception because a variable is undefined. This change defines the variable. It also makes it so that--dataTypecan be passed as a parameter.