This repository was archived by the owner on Feb 13, 2021. It is now read-only.
Dynamically link HIE for great TH speedup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps link to the GHC ticket as well https://gitlab.haskell.org/ghc/ghc/issues/15524 |
infinisil
force-pushed
the
dynamically-linked
branch
3 times, most recently
from
b1ee410 to
8d4c5e5
Compare
See domenkozar/hie-nix#59 Thanks to @mpickering for pointing this out
infinisil
force-pushed
the
dynamically-linked
branch
from
8d4c5e5 to
ab36b32
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See domenkozar/hie-nix#59
Thanks to @mpickering for pointing this out
This will increase closure size by about 50% for each HIE version, but I think this is alright because 4 minute startup time for HIE is unacceptable (which is the startup time for nixbot if I use TemplateHaskell). It's ~4 seconds with this change.
Will merge once the Linux builds are complete and pushed to all-hies cachix.